Tutorial modding fgo jp /na with always your turn/dumb enemy,attack,and noble phantasm

zverilius said:

Screenshots, .png files are not visible, apparently you did not complete the theme, please fix it!

Click to expand...

zverilius said:

Screenshots, .png files are not visible, apparently you did not complete the theme, please fix it!

Click to expand...

Yaskashije said:

Dumb Enemy feature crashes the game during the 1st attack animation. The NP one doesn't seem to work either. Since enemies do get the damage boost, you can't even clear the tutorial with the working feature. I'd like to have someone to repeat the same process as me, and to verify that it's not just me or my emulator. I'm using a predetermined Nox Android 7 stance (non-rooted).

Also, some clarifications or insights are needed:
>The Dumb Enemy feature consists of nopping a huge function (REALLY HUGE). Further IDA inspection proves us this is a complex function (a class or struct type function). BX LRing it out will not be a good idea from the very start (we don't even know a priori wether this func has a return or not).
>There's 3 anticheat functions with those 2 func he mentions to nop, one is wallhack (I dont know why), Speedhack, and Injection integrity check. I edited the injction one. (If it's another func the one that should be nulled, it's OP's fault for not saying specifically which one to edit) .
>There's only one isAddNpPer function, and the tutorial instruction edition doesn't work. (Moreover, it's a void function, you should inspect it using IDA, since there wont be a return, internal registers should be edited)
>Damage one works, but enemies also obtain it. There's 2 functions with that name, but since one returns boolean 0 or 1, I ignored it.


Offset references for current version 2.2.1:
// RVA: 0x140DA7C Offset: 0x140DA7C VA: 0x140DA7C Slot: 6
protected override void DisposeInternal() { }

// RVA: 0x140D65C Offset: 0x140D65C VA: 0x140D65C
private void OnCheatingDetected(string cause) { }

// RVA: 0x1101070 Offset: 0x1101070 VA: 0x1101070
public void addNpPer(float per) { }

// RVA: 0xF161E4 Offset: 0xF161E4 VA: 0xF161E4
public int get_AddAtk() { }

// RVA: 0x179E320 Offset: 0x179E320 VA: 0x179E320
public BattleLogicTask[] taskAIAttack(BattleLogic.LOGICTYPE ltype, BattleData data) { }


Thus, I have the following hypotheses (not in order of how likely I think they are):
1: Tutorial is missing info, OP says he got it working and to trust him. Anybody learning or trying the same process may fail to obtain 2/3 features mentioned (and the one that works makes you unable to even pass the 2nd tutorial fight) [Just like what happened to me].
2: Op didn't test for the features, making this tutorial pointless.
3: Mod works on OP's device but not on every device, so it should be mentioned.
4: Since this game is active, there's chance devs patched his working features, making this post a great example of why tutorials are detrimental to modding community. (Devs also learn from online tutorials)


PS: Since I'm using different offsets (not even the same functions are my references) for my mod, I don't really mind this tutorial being out here, but I felt I should add this comment here so OP may add further clarifications in his tut.

PS2: If it were case 4, I ask OP to not develop further the tutorial with new/different offsets, harm you would cause to mod users would be higher than any good it might bring.

Click to expand...